VBS script not running every time

[Akersar]

Hey, so pretty much, it is as the title states. I have set up a VBS script and it does run but not always. I have to click on it multiple times for it to work. It a script to set up a wallpaper as a background and I have it set with a task scheduler so that it changes wallpapers in relation to the time of the day.
Here is one of the 9 scripts (one for each wallpaper):

dim shell
Set shell = WScript.CreateObject("WScript.Shell")
wallpaper = "C:\Users\Akersar\Pictures\asd\em.jpg"
shell.RegWrite "HKCU\Control Panel\Desktop\Wallpaper", wallpaper
shell.Run "%windir%\System32\RUNDLL32.EXE user32.dll,UpdatePerUserSystemParameters", 1, True

So yeah, it does run, but not every time I double-click on it. Any insights or solutions? I ask you friends!

Thank you in advance

 

[Jaime3d]

When you click on it and it doesn't work, look at the registry at HKCU\Control Panel\Desktop\Wallpaper. Does it update there? That could give you a clue as to where it's hanging up.

 

[Akersar]

When you click on it and it doesn't work, look at the registry at HKCU\Control Panel\Desktop\Wallpaper. Does it update there? That could give you a clue as to where it's hanging up.

EDIT: I have found the registry line for the wallpaper and I see and have confirmed that it changes in the registry, but it does not change the actual background.

 

[Jaime3d]

If you click on it and you do not click on it again, does it eventually change?

 

[Akersar]

If you click on it and you do not click on it again, does it eventually change?

It doesn't seem to eventually change (waited for 8 mins approximately). Must I wait longer?

 

[Jaime3d]

Unfortunately I don't know enough about UpdatePerUserSystemParameters to know for sure, but it seems to be an issue with Windows not knowing to do a refresh on the desktop. It also looks like you're not the only one to have this problem. Check out this thread, it looks like the guy was able to do something different that you can probably try:

http/stackoverflow.com/questions/19721554/rundll32-updateperusersystemparameters-not-working-with-windows-7

 

[Akersar]

Unfortunately I don't know enough about UpdatePerUserSystemParameters to know for sure, but it seems to be an issue with Windows not knowing to do a refresh on the desktop. It also looks like you're not the only one to have this problem. Check out this thread, it looks like the guy was able to do something different that you can probably try:

http/stackoverflow.com/questions/19721554/rundll32-updateperusersystemparameters-not-working-with-windows-7

It seems to be a fix for him, but I'm not sure how to set this up. Do I just replace my other code with this one and save it as VBS again? I get a Syntax error when I try to start it.

 

[Jaime3d]

Yea, that solution isn't VBS, but Powershell instead, which is something I don't know a whole lot about. Not sure if you're solution needed to be VBS or not, but if you aren't opposed to learning a bit about Powershell you might be able to get this to work with little trouble. This might help you as well:

http/stackoverflow.com/questions/9440135/powershell-script-from-shortcut-to-change-desktop/9440226#9440226